Repository navigation
arm64: dts: qcom: sm8250-pico4-phoenix: drop the home, confirm and app keys - #51
Merged
Merged
Conversation
…p keys PICO OS's device tree declares GPIO keys for home, confirm and app besides volume down. The PICO 4 has only the power and volume buttons: pressing each of them on the headset gives KEY_POWER (pon), KEY_VOLUMEUP (resin) and KEY_VOLUMEDOWN (gpio-keys), and nothing else ever reported an event. Drop the three keys and their pin states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For overpressure/phoenix#43.
PICO OS's device tree declares GPIO keys for home, confirm and app besides volume down, and ours took them over. The PICO 4 has only the power and volume buttons: pressing each of them on the headset gives KEY_POWER (pon), KEY_VOLUMEUP (resin) and KEY_VOLUMEDOWN (gpio-keys), and the other three never reported an event. This drops the three keys and the pin states only they used; volume down stays.
Not booted on a headset yet.